Tip Calculator using React

Community feedback

• 

  Asia Ashraf•360

  @asia272Posted 8 days ago

  Great job! 👏 I really appreciate your project—it's excellent! I would suggest adding a README file to your solution. It helps others understand your project better, makes it easier to set up, and improves overall presentation.

  In your README, you can also include:

  • Which challenges you faced and how you overcame them
  • Features of your project.

  This will make your project more detailed and helpful for others. Keep up the good work! 🚀

  Marked as helpful

  1

  ---

  

  kunal90803•460

  @kunal90803Posted 8 days ago

  @asia272 Thanks a lot for your feedback! 🙌 I’ve updated my README file to improve clarity and make it easier to understand. Appreciate your insights! 😊

  1

  

  Asia Ashraf•360

  @asia272Posted 7 days ago

  @kunal90803 No problem! 😊 I’m really happy to see that you updated your README. It will surely help others understand your project better. Keep learning and keep building!

  Marked as helpful

  1
• 

  Simon Hickling•340

  @SimonHicklingPosted 8 days ago

  The total pp calculation appears to be incorrect. The tip calculates well, but the total pp should be taking the total bill amount, divided by the number of people, then adding the tip per person value to this amount. Apart from this, this is good. The only thing I did differently is set a minimum amount of person as 1 (as you can't have less than 1 person). This was just a preference thing though, and you lose the opportunity to add the error message anyway.

  Marked as helpful

  1

  ---

  

  kunal90803•460

  @kunal90803Posted 8 days ago

  @SimonHickling Thank you for your feedback! 😊 My project actually produces the same output as yours; I just wrote the formula differently. The total per person is still calculated by dividing the bill among the people and adding the tip per person, so the final result remains the same. That said, I really appreciate your idea of setting a minimum of 1 person—it’s a great way to ensure valid input without needing an error message. Thanks again for your valuable insights! 🙌

  0
• 

  Simon Hickling•340

  @SimonHicklingPosted 8 days ago

  Are you sure? I just checked again, and if you enter 10 with one person, the output reads 15.00 where it should read 10.50. sorry if this is me being stupid haha

  Marked as helpful

  0

  ---

  

  kunal90803•460

  @kunal90803Posted 8 days ago

  @SimonHickling You're absolutely right—I checked again and found my mistake. I really appreciate you pointing it out! 🙌 I've now corrected it, and everything works as expected. Thanks again for your valuable feedback! 😊

  1

  

  Simon Hickling•340

  @SimonHicklingPosted 8 days ago

  @kunal90803 phew, no worries. Nice job!

  0