Tip calculator app | Vanilla JS by Alexander MP

Community feedback

• 

  Renan Tiscoski•1,240

  @DonUggioniPosted about 2 years ago

  Hey there,

  A few things I've noticed:

  The reset button does not reset the total values, seems to be working with all the other parameters though.

  For the custom tip, you need to convert the value to a number, right now I believe it is returning a string, so it's not doing the math correctly but it's concatenating the string + number.

  You can add an eventListener to all the inputs and pass those into a function that will do the math, after that, then you can create a condition that it only displays the total values after all inputs are filled in.

  Something like this:

  if(!bill || !tip || !numPerson) return;

  That is saying that if any of those values are false, it won't do anything untill all of them are true.

  I hope it helps!

  0