Tip calculator app - HTML, SCSS, JS, FlexBox, Grid, mobile-first & BEM

Community feedback

• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted almost 3 years ago

  Hi @darryncodes, looks pretty good! I personally might try radios for the tips, but that's just my preference.

  Here's a short article on how to deal with the leading zeros.

  Two things I observed is that the grand total for each person is not taking the tip amount, and any bill that has less than $100 would result to NaN . I haven't done this challenge so I don't know if that is intended behavior. There's an error on the console from the regex that might be causing it.

  Hope this helps!

  Marked as helpful

  1

  ---

  

  darryncodes•6,370

  @darryncodesPosted almost 3 years ago

  Hi @emestabillo, thanks for taking the time to comment.

  Radio's is an interesting call.

  Thanks for the article link, that website looks excellent. However I still haven't managed to make it work with the code snippet 😅

  I've fixed the NaN and console error, I had some random bits and pieces knocking about in the code that i left behind accidentally whilst testing stuff out!

  1
• 

  Dev Rathore•2,600

  @GitHub-dev12345Posted almost 3 years ago

  Your design have over size I suggest you, you this css property to decrease and increase your whole size of design , 😊😊

  0
• 

  Dev Rathore•2,600

  @GitHub-dev12345Posted almost 3 years ago

  Good Work Bro ❤️👍 My small suggestion : 1.In Card design CSS Code Used this:

  transform : scale(0.8); this property decrease the size of card. 😉

  large size for increase the number of scale & small size for decrease the number of scale

  I hope you find this helpful

  0

  ---

  

  darryncodes•6,370

  @darryncodesPosted almost 3 years ago

  Hi Dev, thanks a lot and for the comment.

  I don't really understand what you mean - what problem would your feedback solve?

  0