Time-Tracking-Dashboard-CSS-Grid

Community feedback

• 

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  Hi there. You did a good job 😎

  keep improving your programming skills🛠️

  your solution looks great, however, if you want to improve it, you can follow these steps:

  ✅ pay attention to the automatic report on your solution. you need to fix html and a11y errors

  ✅ Disallow css native @import . CSS font @import prevents parallel downloads, use <link> instead.

  ✅ Use relative units for font size . While modern browsers can smoothly zoom pixel-based layouts, sizing type in relative units ensures an entire layout can be scaled up or down by simply updating the font-size of the body element.

  .container{
      max-width:1140px;   <-----
      width:90%;
      margin:2em auto;
  }
  
  @media (min-width: 768px) and (max-width: 991px) {
  

  ✅ DONT repeat yourself . You can loop through keys and set all this properties in 5 line of code

                if(day==="weekly"){
                   
                  datas=((Object.entries(titles.timeframes.weekly)))    
                  this.addData(datas,activityType);
                    
                }
                 
      
                if(day==="monthly"){
      
                  datas=((Object.entries(titles.timeframes.monthly)))     
                  this.addData(datas,activityType);
                 }
  

  I hope my feedback will be helpful. You can mark it as useful if so 👍 it is not difficult for you, but I understand that my efforts have been appreciated

  Good luck and fun coding 🤝⌨️

  Marked as helpful

  1

  ---

  

  Yehan Nilanga•670

  @Yehan20Posted over 2 years ago

  @isprutfromua hey thanks so much , much appreciated and i think i used relative units for font size in rems, I used px in only one occasion , i think because i didnt want the padding to increase , that's why.

  0