Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I am proud of the project outcome.
What challenges did you encounter, and how did you overcome them?Challenges include:
- Using the json file. I did not eventually use it and I would learn more on how to use it.
- converting font size from px to rem in sass was a bit tricky as '/' was an issue. I used sass maths instead.
- I was unable to use grid-areas in Sass. A solution to this would be greatly appreciated.
- I would also like a code review with pointers on how to improve my code.
- Finally, I'm wondering if it's possible to use wrap in grid or if I have to use auto-fit or minmax?
Community feedback
- @Hossein-H-IPosted 19 days ago
Hi my friend everything is fine in your solution but if you add some code to your CSS, it can be more better. for body add these code : min-height: 100vh; display: flex; flex-direction: column; align-items: center; justify-content: center; and for main tag add some max-with for example this code: max-with: 900px ; or anything you want to prevent container from getting too width value
0@Ejiro-FrancesPosted 19 days agoThank you @Hossein-H-I for taking time to review my work. I will effect the corrections as suggested.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord