Testimonials slider challenge

Community feedback

• 

  Miguel Silva•510

  @migsilva89Posted over 2 years ago

  Good job with the challenge.

  I think that you should take out position:absolute for the mobile version and use grid (1col 2 rows) for the mobile.

  I also see that you are missing the background image on the desktop version.

  Let me know if you need any help I can push your code and make some fixes.

  regards, Miguel Silva

  Marked as helpful

  1

  ---

  

  Aya•150

  @aya-94Posted over 2 years ago

  @migsilva89 Hey! thanks for the review! yeah I realized that the background image in the code I uploaded was still located in the file (which I don't have in GitHub), so I edited the code in GitHub but I don't know why it's not showing the changes on the page :( so if you know how to solve it, it will be helpful. previously refreshing solved it, but unfortunately not on this one. yeah, I really need to practice the responsive part, I'll try to check the grid properly and do a project based on grid and flexbox, thank you!

  0

  

  Aya•150

  @aya-94Posted over 2 years ago

  @migsilva89 BTW, in my report I received a lot of landmark issues in the accessibility part, do you know to tell if it's important? as it was marked as a warning. asking because I didn't understand well what I should change.

  Thank you!

  0

  

  Miguel Silva•510

  @migsilva89Posted over 2 years ago

  @aya-94 Yes it is very important.

  Without the usage of landmarks and headings, we seriously disaffect screen reader users, effectively forcing them to Tab through the entire website in the pursuit of desirable content. Evidently, incorrect usage (or no usage) of landmarks, heading levels, and labelling is a deeper indication of accessibility problems.

  You can see more about accessibility and semantic HTML here:

  • http://web-accessibility.carnegiemuseums.org/foundations/semantic/#:~:text=Structural%2C%20semantic%20HTML%20is%20the,read%20by%20a%20screen%20reader.

  • https://levelup.gitconnected.com/build-an-accessible-html-structure-using-aria-landmark-regions-and-headings-4647d22c2cc7

  regards Miguel Silva

  1

  

  Aya•150

  @aya-94Posted over 2 years ago

  @migsilva89 Thank you so much!

  0