Testimonials-grid-section-HTML-SCSS-GRID-Layout-BEM-FLEXBOX

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted 4 months ago

  Hey there @juliengDev 👋! Here are some suggestions to help improve your code:

  • There is no header in this challenge since, as the name of the challenge states, it is a section of a site; so remove all the header elements you added.

  • For the "quotes" img, use the background-image element.

  • The article element is not the best choice ❌ for wrapping these testimonials. In order to use the article element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site). These testimonials cannot do neither.

  • For the testimonials, it is best to to wrap each individual testimonial component in a figure element, the individuals information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  • The headings in your component are being used incorrectly❌. Since the h1 heading can only be used once ⚠️, it is always given to the heading with the highest level of importance. This component has several headings of equal importance, so the best option would be to use an h2 heading ✅ since it is reusable and it will give each heading the same level of importance.

  • The only headings ⚠️ in this component are the names of each individual; “Daniel Clifford”, “Jonathan Walters”, “Jeanette Harmon”, “Patrick Abrams” and “Kira Whittle”. Everything else should be wrapped in a paragraph element.

  <Happy Coding/>! 👾

  Marked as helpful

  1

  ---

  

  P

  Gilbert•360

  @juliengDevPosted 4 months ago

  Thank you, @VCarames, for all the suggestions.

  I followed your recommendations and made the changes. They helped me improve my HTML knowledge.

  I hope you can provide more recommendations in the future, and I can learn from you again.

  Take care.

  1