Design comparison
Solution retrospective
I tried BEM methodology for naming classes. Please review the class names, if they are according to BEM or not. Any other suggestions are welcome.
Community feedback
- @Pranshu-SahuPosted almost 2 years ago
Hi! 👋
Congratulations on finishing this challenge! 🎉
Some suggestions from me.
--In order to remove accessibility error for
Page should contain a level-one heading
- You have givendisplay:none
toh1
inside the main container instead giveh1
class ofsr-only
.sr-only{ position: absolute; width: 1px; height: 1px; padding: 0; margin: -1px; overflow: hidden; clip: rect(0, 0, 0, 0); white-space: nowrap; border-width: 0;}
this would improve your accessibility of the site.
Related resources:
How-to: Accessible heading structure - The A11Y Project
I hope this helps. Happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord