@Alexandru736
Posted
Hi! The design of your project looks good with little exceptions of color choosing for some fonts. However, since you choose to use SASS as a way to work more efficient on your CSS, I would like to share some feedback with you:
- First, modularity is one of the biggest assets you could use if you chose SASS. For example, if you have multiple cards, you can observe that they share the same html with only the change of colors. Therefore, you could use
mixins
like a programming function to modularize that part. - Second, I saw you used
grid-column
andgrid-row
to insert the cards in the order you desired. This approach is flawed due to the fact that if you had even more cards, you could easy mess the code. Thus, you could usegrid-template-areas
to be more efficient. Keep up with the next projects!
Marked as helpful
@Kikino02
Posted
@Alexandru736 Hi! Thank your for the tips.. I rewrited the code and it looks nicer :)