Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?.
What specific areas of your project would you like help with?.
Community feedback
- @Alexandru736Posted 5 months ago
Hi! The design of your project looks good with little exceptions of color choosing for some fonts. However, since you choose to use SASS as a way to work more efficient on your CSS, I would like to share some feedback with you:
- First, modularity is one of the biggest assets you could use if you chose SASS. For example, if you have multiple cards, you can observe that they share the same html with only the change of colors. Therefore, you could use
mixinslike a programming function to modularize that part. - Second, I saw you used
grid-columnandgrid-rowto insert the cards in the order you desired. This approach is flawed due to the fact that if you had even more cards, you could easy mess the code. Thus, you could usegrid-template-areasto be more efficient. Keep up with the next projects!
Marked as helpful0@Kikino02Posted 5 months ago@Alexandru736 Hi! Thank your for the tips.. I rewrited the code and it looks nicer :)
0 - First, modularity is one of the biggest assets you could use if you chose SASS. For example, if you have multiple cards, you can observe that they share the same html with only the change of colors. Therefore, you could use
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord