Testimonial Grid with Mobile First + GRID + Responsive

Community feedback

• 

  P

  Remus D. Buhaianu•3,125

  @MiculinoPosted almost 3 years ago

  Good job on completing the challenge, Aakash!

  Your final solution looks good and I like how responsive you've made it. I have to admit that I was surprised to see that you had over 800 lines of code :)

  Btw, I think this resource will be useful to you https://css-tricks.com/look-ma-no-media-queries-responsive-layouts-using-css-grid/

  At around 1073px resolution, some of the cards' height don't span completely to the bottom, so you might want to review some of the code that affects the row and column span of the grid items.

  Good job again on finishing this challenge!

  Marked as helpful

  2

  ---

  

  Aakash Verma•6,710

  @skyv26Posted almost 3 years ago

  @Remus432 Thank you Remus, I think I need work more on Grid, As i made project using grid, but long time ago, that's why while working on this I really messed up. But Sure 😊 I will check that link for reference and soon I will upload new solution based on Grid

  0
• 

  Elroy Toscano•630

  @elroytoscanoPosted almost 3 years ago

  Hi Aakash, good job with the design. There's just a little box shadow missing on Kira and Jeanette's cards.

  Seeing through your code, you've used p tags for each article's title/persona name, instead, swap them for h2 tags to improve the semantic correctness as even each article/section needs a heading tag.

  Download AXE dev tools so that you can clear any accessibility issues while coding : https://www.deque.com/axe/devtools/

  Hope this helps.

  Marked as helpful

  1

  ---

  

  Aakash Verma•6,710

  @skyv26Posted almost 3 years ago

  @elroytoscano Thanks, but I think there is no need of heading inside the article.

  0
• 

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  Great work friend! Looks good and is very responsive. One thing I notice is that Jonathan, Jeanette and Kira's boxes become small, so you might want to add a minimum height or something

  Marked as helpful

  1

  ---

  

  Aakash Verma•6,710

  @skyv26Posted almost 3 years ago

  @anoshaahmed Yes, Anosha, I really messed with this, honestly I am not happy with this solution.

  1

  

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  @skyv26 If your "messy solution" can work about perfectly, then that just shows that you're good at what you do, and you know what you can do

  Marked as helpful

  1