Stats-preview-card-component using scss

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Muhammad Ain Uddin! 👋

  Well done on this challenge! There's not much to add since you did great job on this challenge. Maybe take a look at:

  • Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.

  Keep up the good work! 💪

  0

  ---

  

  Muhammad Ain Uddin•40

  @muhammad-ainuddinPosted over 3 years ago

  @tediko Thank you so much for your feedback! I forgot to visit the website. I wanted to ask what semantic tags you would use in building of this card component?

  0

  

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  @muhammad-ainuddin Not much to be honest. You can change your .card container into <section>. It is good read tho so just want to link it to you ;)

  1

  

  Muhammad Ain Uddin•40

  @muhammad-ainuddinPosted over 3 years ago

  @tediko Thank you so much for taking time to answer me, and yeah the article was a good read, learned some new stuff. Thanks again!

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  looks good but in your transition between desktop and mobile the layout seems a little short. It would be nice if it was taller and showed more of the top image without it being cropped so much

  0

  ---

  

  Muhammad Ain Uddin•40

  @muhammad-ainuddinPosted over 3 years ago

  @palgramming Thank you so much for your feedback. I completely forgot to visit the website.

  0