stats preview card-component main challenge solution using Html & css

Community feedback

• 

  P

  Grzegorz Sterczewski•680

  @gsterczewskiPosted over 3 years ago

  Hello Vishal-wankhade 👋, my name is Grzegorz.

  I think you set incorrect url for background-image, for now it doesn't show up.

  I would also rethink usage empty article for displaying image as a background.

  article should be used for displaying stand-alone content, right now there is no content at all. Perhaps img element would be more suitable here.

  I hope this will be helpfull to You.

  Keep up the good work! 💪

  See you on the coding trail 😉

  Cheers!

  Marked as helpful

  0

  ---

  

  vishal wankhade•495

  @Vishal-wankhadePosted over 3 years ago

  @GSterczewski No, I have given the accurate path and it's showing the image in my browser , I don't no why it's not showing here. for the background image , image tag would be better I agree with you. thanks for the feedback

  0

  

  P

  Grzegorz Sterczewski•680

  @gsterczewskiPosted over 3 years ago

  @Vishal-wankhade

  I can see the image when I change the path from images/image-header-desktop.jpg to image-header-desktop.jpg On your github source code, you don't have the images folder.

  1

  

  vishal wankhade•495

  @Vishal-wankhadePosted over 3 years ago

  @GSterczewski oh ok thank you got it now.

  0
• 

  Ediongsenyene Joseph I.•1,675

  @IEdiongPosted over 3 years ago

  Hello Vishal 👋

  Congratulations on your first FEM Challenge.

  Here are some things you should look into:

  • Your use of semantic tags, eg you shouldn't have more than one <h1> tag in your page. Other matters that relate to this are in the report above.
  • Your image seems not to be displaying on small screen sizes.
  • You could remove border-radius: 10px; from .image and #overlay, then put it only in the div.contianer and also set overflow: hidden; on it too.
  • Also look into working on your responsiveness.

  I hope this was helpful, happy coding 💻🥂

  Marked as helpful

  0

  ---

  

  vishal wankhade•495

  @Vishal-wankhadePosted over 3 years ago

  @IEdiong thanks for the feedback. I only made the responsiveness design for 375px as given in guidelines with max-width 500px . and showing the images in my browser. about the border radius, it was a better option to go with .

  as I am new here . don't why it's not showing the image here. everything correct and totally working in my browser would you tell what could be the problem here

  0