Stats Preview Card Component with Sass

Community feedback

• 

  Vanza Setia•27,755

  @vanzasetiaPosted over 3 years ago

  👋Hi Eduard Mekler!

  I have some feedback on this solution:

  • For the stat, I recommend to use ul and the child element would be li.
  • You should not apply desktop layout on 376px, since it's too early. My recommendation is that don't take the design width as your breakpoint. You should resize your browser open dev tool to see when it has enough room to become two columns.
  • Some best practices to follow, use rem or sometimes em units for almost everything and use BEM Methodology to name your classes.

  That's it! Hopefully this is helpful!

  Marked as helpful

  1

  ---

  

  Eduard Mekler•60

  @emekler0729Posted over 3 years ago

  @vanzasetia Thanks! I came back to this project and implemented some these suggestions as well as using Sass.

  0
• 

  Burak CLN•385

  @brkclnPosted over 3 years ago

  When i resize it, its overflowing.. Like this: https://prnt.sc/1j9bwno (after 376px)

  0

  ---

  

  Eduard Mekler•60

  @emekler0729Posted over 3 years ago

  @brkcln fixed it. :)

  1