hitmorecode• 6,250
@hitmorecode
Posted
Nice well done. I have a few suggestions
- Why are you using two overlays? You only need one.
- The blend mode overlay with the image should be multiply
- Right now you are using three different measurements units px, em and rem. Avoid this at all time, stick to one.
I know it can be a bit tedious to convert px to rem all the time. Here is a trick to fix this. I've only tried this with rem so I don't know if it will work with em.
In your CSS add this to the :root and body
:root {
font-size: 62.5%;
// this wil convert the default value of 16px to 10px
// turning it into a 10 based system
}
body {
font-size: 1.6rem;
// this will change back to the default value of 16px
// and because it's 10 based system, now you can easily
// convert pixels into rem, all you have to do is divide the number of pixels by 10
// so 120px = 12rem, 10px = 1rem and so on.
}
I hope you found this feedback helpful
Marked as helpful
0
Dolla464• 140
@Dolla464
Posted
Thank you for your tips, it was very helpful. I will work on it. @hitmorecode
0