Stats preview card component

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 3 years ago

  Hello

  First you definitely need to make the text readable - black on a dark background doesn't work

  This looks very very narrow on my phone screen. You want content to get closer to the edges so you can use more screen estate. The padding inside the card is also large on mobile making written content even narrower

  Looks like the issue is because you're using widths in percentage. Not a great idea as you're losing control of the layout. Use max-width instead, let it grow to a point. Then a little margin on the component or padding on the body to stop it hitting screen edges

  Remember font size must never be in px. Use rem

  And in html the words like companies should not be in paragraph tags. They don't need to be wrapped in anything as they are already inside a meaningful element (list item)

  I can see you're importing your fonts twice in the head of the doc. Did you mean to import 2 different fonts? If so, do that all in the same link, no need to have all those Google font links twice.

  Please update this solution to remove these tags! This challenge does not use any of things you've tagged it with

  Hope this helps

  Marked as helpful

  1

  ---

  

  Hamza-Noah•300

  @Hamza-NoahPosted almost 3 years ago

  @grace-snow Hey thanks for the feedback I updated all that you mentioned. but the design comparison gives different font family on numbers why is that and is the design works well now for small screens I am trying to improve my responsive skills

  0

  

  T

  Grace•31,270

  @grace-snowPosted almost 3 years ago

  @Hamza-Noah do you mean the Stats numbers like "10k"? I assume it's either that they should be using the other font family "Inter", sans-serif or you may just need to generate a new screenshot? The numbers should not be uppercased either and the spacing looks a tiny bit bigger on your solution.

  I wouldn't really worry about most of these things though. If you were in a real job or had pro membership, you'd have that level of detail from the design file. I think this is pretty close to the design

  Marked as helpful

  0