Space Tourism with React

Community feedback

• 

  P

  Nikita Vologdin•660

  @NikitaVologdinPosted about 2 months ago

  Great job @sophia-see! A few things to mention:

  • check lighthouse metrics (last tab in google chrome dev tools) it will help you to make some small improvements crucial for the SEO.
  • for time-saving, you may use an opacity: 50% for the inline elements to match the Figma design rather than save colours to CSS variables.
  • In React also, layout changes can be achieved by changing flex and grid properties in the CSS media queries, so there is no need to get viewport sizes using JS.
  • Home Layout looks much better if switch off /* height: calc(100dvh - 112px); from .container.
  • In Dialog you may remove the gap between elements because you have quite big padding there. By the way if you did it for accessibility purposes (fat finger problem), 15px padding should be enough. To follow the design you can take a gap from there 32px and subtract 15px, the result is a gap value for the flex container.

  Love your work, thank you for reading, I hope I have been a bit helpful.

  Marked as helpful

  1