Skip to content
Submitted almost 3 years ago

Space tourism mobile first(SCSS, flexbox, Vanilla JS, API)

Christian Glenogo•130
@CHRISTIANGLENOGO
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Space tourism multi-page website
  • HTML
  • CSS
  • JS
3intermediate

Design comparison

SolutionDesign

Solution retrospective

I really take extra effort to make everything close as possible to the design and responsive. This also my first time to used fetch API and I would appreciate any feedback on which part of the code needs improvements. Thanks

Community feedback

  • Aakash Verma•6,710
    @skyv26Posted almost 3 years ago

    Hi! Christian, Really nice work dude. I checked your design responsiveness. I have noticed one issues

    Issues

    1. At 375px OR below 375 and above 320px. there is some white space at the bottom of your design. You can see this also by inspecting.

    Suggestion

    In order to solve your accessibility issues, just wrap your section content (section next to header) with main tag. It will solve this your issue

    like

    
<header>
   . ..
     ...
       ... 
</header>
<main>
            <section>
                     ...
                        ...
 .                          ...
             </section>
</main>

    It will solve your accessibility issues.

    Overall very well done. I liked your work.

    Best Wishes

    Marked as helpful
    0
  • Christian Glenogo•130
    @CHRISTIANGLENOGOPosted almost 3 years ago

    Thanks Dude. Noted on that!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord