Some clamp() and animations for you! - Article preview - HTML, CSS, JS

Community feedback

• 

  Ahmed Faisal•5,095

  @afrusselPosted over 3 years ago

  Good work. I think you also use a toggle function for animation. And if you want to make your work like the design check my solution

  Marked as helpful

  1
• 

  Mustafa•415

  @Mostafa-TPosted over 3 years ago

  Its perfect !! 🔥 there is a little adjustment for a better look which is the box-shadow of the main container could have more blur

  Happy coding 👨🏾‍💻

  Marked as helpful

  0
• 

  Fidel Lim•2,775

  @fidellimPosted over 3 years ago

  Great work! That's some nice animation you have for the share button. Just a suggestion maybe if you're interested in doing some update for this challenge is that you can add a "cursor: pointer" to the share button as you hover it. So that the user can notice that it is clickable. Also, on your script file, instead of adding an event listener on the body tag, you can just use "toggle" function. You can remove the the body event listener then replace "activeState.classList.add("visible")" with "activeState.classList.toggle("visible")". So that, whenever a user presses the share button, the popup will just disappear again. I hope this helps :)

  Marked as helpful

  0

  ---

  

  Stefano•155

  @StefanoDeCapitaniPosted over 3 years ago

  @fidellim Thank you very much for the advise, I've never used "toggle" function. I'm going to study it and than I'll try to update the solution :)

  0

  

  Fidel Lim•2,775

  @fidellimPosted over 3 years ago

  @StefanoDeCapitani good luck!

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  The overall size of your card is MUCH to big when compared to the layout. It looks like you have all the elements to have a good challenge result but your current sizing issue is keeping that from happening

  Marked as helpful

  0

  ---

  

  Stefano•155

  @StefanoDeCapitaniPosted over 3 years ago

  @palgramming You're right! I spent so much time on other issues that when I had all of that working quite properly I wanted to move on and submit the solution, despite the different sizing. I know, I've been lazy...but now that you have pointed it out, I'm going to fix it ;D

  0