Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Solução usando HTML, CSS e Grid

#accessibility

@RaizaCirne

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


O que você achou difícil ao construir o projeto?

Community feedback

Ecem Gokdogan 9,380

@ecemgo

Posted

Some recommendations regarding your code that could be of interest to you. 🤗

HTML

In order to fix the accessibility issue:

  • Each main content needs to start with an h1 element. Your accessibility report states that the page should contain a level-one heading. So, you need to use a <h1> element in the <main> tag instead of using the <h3> element. You can replace the <h3>Improve your front-end skills by building projects</h3> element with the <h1>Improve your front-end skills by building projects</h1> element.

CSS

  • If you want to center it correctly, you can update your body in this way: (after doing it, please remove main because you don't need main anymore in your CSS file 🤗 )
body {
  padding: 0px;
  margin: 0px;
  background: hsl(212, 45%, 89%);
  font-family: "Outfit", sans-serif;
  min-height: 100vh;
  display: grid;
  place-content: center;
}

Hope I am helpful. :)

Marked as helpful

0

@RaizaCirne

Posted

@ecemgo Thanks. The changes were made!

1
Ecem Gokdogan 9,380

@ecemgo

Posted

@RaizaCirne I'm happy to help, happy coding! :)

1

@0xabdulkhalid

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HEADINGS ⚠️:

  • This solution has also generated accessibility error report due to lack of level-one heading <h1>
  • Every site must want at least one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

@RaizaCirne

Posted

@0xAbdulKhalid Thanks. The changes were made!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord