@DylandeBruijn
Posted
@juliengDev
Hiya! š
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution š
- Use of semantic HTML elements
- Clear descriptive CSS classes
- Use of CSS custom properties
Things you could improve āļø
-
I suggest adding a bit of
paddingto yourbodyelement so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vhto yourbodyelement so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
The
mainelement should be only used once for the main content of your page. -
Try wrapping your links in
atags in your list.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! š
Let me know if you have more questions and I'll do my best to answer them. šāāļø
Happy coding! š
Marked as helpful
@DylandeBruijn
Thank you so much for your detailed and constructive feedback! I really appreciate the time you took to review my code and provide such helpful insights. Your comments will definitely help me improve and grow as a developer. Your suggestions for improvement are excellent, and I'll be sure to implement them right away. They are all great points that I'll keep in mind for this project and future ones. Your feedback is incredibly valuable, and I'll certainly mark your comment as helpful. It's motivating to receive such thoughtful guidance from fellow developers. I look forward to applying these improvements and continuing to learn. Wishing you all the best, and I hope we have the chance to exchange ideas again in the future! Happy coding to you too! āļøš§š±
