Design comparison
Solution retrospective
Hi guys! Just completed another challenge 🚀. I really enjoyed this one. I sneaked in an extra rating card ⭐ and a testimonial card for mid-sized devices 😁. Lemme know what you guys think. 👍 or 👎
Community feedback
- @AgataLiberskaPosted over 3 years ago
Hi @dewslyse, it does look nice and symmetrical, but I don't really see the point of an extra card if you've only got three on mobile and desktop. Plus styling three elements is trickier than 4, so it could be a nice challenge.
Other than that though, nice work - I don't see any issues at all. It's nice that you use semantic HTML - you could also use
article
for your individual feedback cards, just remember to include a heading element too. It's also nice to see that you made it work even on narrowest screens, many people don't think about it :)Marked as helpful1@dewslysePosted over 3 years ago@AgataLiberska, thanks for the feedback and suggestion. The idea was to have the page looking nice and symmetrical. It was actually an afterthought. Granted, adding the additional cards was not as challenging, but I did style the three elements. I just didn't like the output.
I'll do well to include more semantic tags in subsequent challenges. All screens deserve love 😄
0 - @benjoquilarioPosted over 3 years ago
Congrats on finishing this one!
It looks good and response very well and I like the idea of yours adding a new feedback for tablet screen sizes, to make the design looks great.
My only small suggestion is change the px into rem for relative units. https://engageinteractive.co.uk/blog/em-vs-rem-vs-px
that's it keep coding
Marked as helpful0@dewslysePosted over 3 years ago@benjoquilario, thanks for the feedback and suggestion.
Happy coding...
0 - @brendanmaddenPosted over 3 years ago
Looks really, really, good, @dewslyse! 🎉 Nice work! I think I could learn a thing or two by looking through some of your code! Nice fluid responsiveness, and I love the Dews Original card in the tablet view 😂 Looking forward to seeing what you build next!
1@dewslysePosted over 3 years ago@brendanmadden Thanks for the kinds words. No pressure!!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord