Social Proof Section w/ Flexbox, SASS

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Dex! 👋

  Congrats on finishing another challenge! Your solution responds well. Here's my few suggestions:

  • You repeat your HTML code with stars images which is unnecessary. Find the way to use only one star image for a .rating-stars. You can do it easily by using background-repeat approach in your css.
  • Read about Sass 7-1 pattern to keep your file management orginazed.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Dex•225

  @tihuskyPosted over 3 years ago

  @tediko Thanks for your feedback!

  I know about the 7-1 pattern but I felt like it'd be overkill for this small challenge and tried to keep things simple 😅

  As for the stars, as far as I'm aware there's no way to make the background repeat a fixed number of times, right? So I guess I'd have to make the container 5 times as wide as the star image. But then I'd have to adjust that size if I'd later decide to use a star image with different dimensions. I'll experiment with this a bit! 🤔

  1

  

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  @tihusky Yeah, it'd be a overkill for such a small project :D

  0