Social Proof Section using SASS, mobile-first

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted almost 4 years ago

  Hello, Nicole! 👋

  Congratulations on finishing another challenge! Your solution responds quite well and looks nice. What I can suggest is:

  • You repeat your HTML code with stars images which is unnecessary. Find the way to use only one star image for a .stars etc. You can do it easily by using background-repeat approach in your css.
  • Yes, there is a better solution to position your ratings. One of them is to remove margin-left from all review-boxes then to .ratings div add padding-left: 2rem; max-width: 550px; width: 100%; (you'll work on them later, i just put them to show you how it works). Next, add to .report-rating div align-self: center and to .besttech-rating div align-self: end;. Lastly add width: 100% to .review-box class.

  This is my approach to this challenge. Like most people here, I also learn but maybe you will find something good for yourself.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Nicole•360

  @nicole-tuznikPosted almost 4 years ago

  @tediko thank you, I can't believe I forgot I could use the align-self property to do the same thing, that's so much better. I really appreciate all your help!

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Nicole! 👋

  Nice job on this challenge! Your solution looks good and responds nicely! 👏

  One tiny suggestion in addition to tediko's helpful feedback—there's rather a lot of space between the testimonials and the bottom of the page in the desktop layout. Allowing the height of the .testimonial-cards container to be determined according to its content and adding min-height: 100vh to the body should help decreases that space and make your solution fit the viewport a little more snuggly! 😉

  Keep coding (and happy coding, too)! 😁

  0

  ---

  

  Nicole•360

  @nicole-tuznikPosted almost 4 years ago

  @ApplePieGiraffe thanks so much, I hadn't noticed the spacing and it looks a lot better now. I appreciate your help!

  0