Social Proof Section used HTML and CSS.

Community feedback

• 

  Muhammad Shajjar•1,100

  @muhammadshajjarPosted about 3 years ago

  Hey Daniel! Well done, it looks great

  I have some suggestions for you.

  • read this it would help you regarding use of strong .
  • Try to center your content, flex or grid helps you a-lot and don't forget to add min-height:100vh by not adding height you will get into trouble while centering with them
  • Try to add max-width to your body or make a container class that wraps your all content, by adding it you can control your content from growing too much on larger viewports
  • For the testimonial quote, I recommend to use block-quote for more semantic HTML check out this for information

  Thanks.

  Marked as helpful

  1

  ---

  

  Daniel Jansen van Vuuren•120

  @DanielJvVPosted about 3 years ago

  @muhammadshajjar

  I just wanted to thank you. I made all the changes that you suggested and you were right. It all just works so much better now. Thank you very much I have learned something new and I hope I'll remember it for the future.

  0
• 

  Dharmik_487•1,740

  @Dharmik48Posted about 3 years ago

  Hey Daniel👋,

  Good job on completing the challenge! But.. here are things you can improve:

  • Firstly the card isn't centered vertically on bigger screens, try add a height of 100vh.
  • Also try using more semantic html tags like, instead of the div with class header use the header tag.
  • And you have used strong tag, and I personally would have used CSS for that.

  Keep Developing👍

  Marked as helpful

  1

  ---

  

  Daniel Jansen van Vuuren•120

  @DanielJvVPosted about 3 years ago

  @Dharmik48 Hello, Thanks for the advice. I just have one question. What size screen are you viewing it on? I'm not really that familiar with the vh unit. I'll have to look into it more.

  0