Social proof section master solution

Community feedback

• 

  hitmorecode•6,290

  @hitmorecodePosted over 1 year ago

  Congratulations well done. Just a few pointers

  • You used way too many media queries. One or two should be enough
  • The content is not in the middle of the page

  body {
      background-color: var(--clr-Light-Grayish-Magenta);
      font-size: 15px;
      font-family: var(--ff-League-Spartan);
      min-height: 100vh;
  /* add flexbox on the body, to place the content in the middle of the page */
      display: flex;
      justify-content: center;
      align-items: center;
  /*     margin: 5rem 0; */ /* remove this line */
  }
  

  0

  ---

  

  Younes Adjoudj•240

  @younesadjoudjPosted over 1 year ago

  @hitmorecode Thank you very mush. I have one question please: In my css I used a lot of position (relative), do you think it's a good practice ?

  0

  

  hitmorecode•6,290

  @hitmorecodePosted over 1 year ago

  @younesadjoudj this is a no right or wrong answer, you manage to do it so it's ok. But I will say this avoid using position if it's not necessary. Try to lean more towards flexbox or css grid. For example the three cards you could aligned them horizontally with flexbox and then with position to move it downwards.

  I mean you made it and it looks good with just position, but if you want to make it responsive it will be a lot of work. With flexbox or css grid you can do it much easier.

  If you are not familiar with flexbox or css grid check these tutorials on youtube

  Colt Steele - Flexbox Tutorial

  Wes Bos - CSS grid course

  Marked as helpful

  0