Design comparison
Solution retrospective
Hi everyone, I want you to help me peruse this work of mine for corrections. Thanks, and happy coding
Community feedback
- @tedikoPosted over 3 years ago
Hello, sylvamadu! 👋
Congratulations on finishing another challenge! Your solution responds quite well and looks nice. What I can suggest is:
- You repeat your HTML code with stars images which is unnecessary. Find the way to use only one star image for a
.stars
. You can do it easily by usingbackground-repeat
approach in your css.
Good luck with that, have fun coding! 💪
1@sylvamaduPosted over 3 years ago@tediko Wow! thanks for revealing this CSS hack to me. I just recalled that such technique still exist. Thanks for pointing out the unnecessary codes in my html. I look forward to working with you in terms of perusing my work as I gradually release them.
0 - You repeat your HTML code with stars images which is unnecessary. Find the way to use only one star image for a
- @suvankarpradhanPosted over 3 years ago
Good job.. Here you wrote srcset in img tag like, "<img src=
/img/icon-star.png
alt=srcset=
>", if you remove srcset from your img tag, you get no html issues.second html issue is, you wrote h3 tag between small tag, here you can use h4 or h5 or h6 tag, but don't use small tag like this way.
Thank you.
1 - @sylvamaduPosted over 3 years ago
Thanks for your response, I deeply appreciate this. I will work on this correction. Thanks and happy coding.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord