@hitmorecode
Posted
You forgot to upload the css file to github. There is no style on the page, so it's hard to comment.
Regarding the given desktop dimension of 1440px, I personally use this as the width of my container and not as the viewport itself. Your work doesn't need to be 100% like the design, if you are in the range of 90% to 95% then it's ok. I change the fonts size all the time, just because the font size on the style guide file sometimes seem to of. As long as you can recreate the layout and it's responsive it's ok.
Marked as helpful
@hitmorecode
I was doing a minor adjustment, so probably the cause of the hiccup. Everything is up on the repository now. If you want to check it out, would help a lot :)
As for the given desktop dimension, yeah makes sense. I would feel more comfortable like that as well. But sometimes I do have the urge to nail the design almost pixel perfect hah.
@hitmorecode
Posted
@MarioMinchevski I used to be like that too every time I wanted to upload finished challenge, it would take me like 1hr or more. Sometimes the uploading took me longer than doing the challenge. Just to make it pixel perfect 😅. Now if it's close to the original I'm happy with it.
I took a look at what you did and it looks good, I would only change one thing, the breakpoint, set it to 1150px. When going lower than 1150px the elements start to overlap and this only gets corrected at 376px.
Marked as helpful
