Design comparison
SolutionDesign
Solution retrospective
- Would it be better if I had used a header tag for the title section?
- I converted almost all my px values to rem. Overkill or good job?
- When I change screen width, the background "moves" relative to the page content. Is this okay? Or should they stay in the same place relative to the content?
- To test my changes, I take screenshots of the page then reduce the opacity and lay them over top the design images to evaluate how they match up. (I do this in Illustrator.) Is there a better way to test changes?
- Anything else you can share with me. Thanks!
Community feedback
- @GrzywNPosted over 2 years ago
Great job!
- You can use header tag, it's more about how you see your site than something being correct or not correct. If you see your project being section for some other page you can wrap everything into main tag as you did. If you see your project as a whole website, you can use header instead.
- Great job, as you did, you should use rem units all the time. Sometimes pixels are converted to rem with precision loss, so be careful. You can use VS Code extension to alternate between px and rems with one keyboard shortcut.
- I think it looks great, you can take a look at other solutions to see how others handled this thing.
- To match the design with your project:
- you can set your background to design image
- you can use DiffChecker website
- you can use PerfectPixel extension for Google Chrome
Hope this helps! Keep coding and have a nice day!
Marked as helpful2@jaycgreenwaldPosted over 2 years ago@GrzywN Many thanks for your detailed answers to all of my questions. The VS Code suggestion is amazing. (I'm currently finding the value in pixels then doing the math to convert to rem.) I'm excited to try out the tools you suggested for comparing my work to the design images. Thank you again and cheers!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord