Design comparison
Solution retrospective
I think I was able to make a good structure to work with the HTML and CSS.
What challenges did you encounter, and how did you overcome them?The most difficult part was to set the links and style for the buttons for hover. Without having the default link with the text decoration. I reaserch in the documentation and finally with the help of chatgpt I end up not using an "onlick" attribute in the HTML.
What specific areas of your project would you like help with?I am not sure if it is a best practice to set the width and heigth of the main card, specially in px that it is a fixed unit. But I don't know how to make it of the size that I want, in other way. Or when it is appropriate to use max-with.
Community feedback
- @StroudyPosted about 1 month ago
Amazing job with this! You’re making fantastic progress. Here are some small tweaks that might take your solution to the next level…
- Your heading elements
<h2><h4>
Missing<h3>
, Heading elements should be in sequentially-descending order (e.g.,<h1>
,<h2>
,<h3>
) to create a clear content structure, improving accessibility and SEO. Skipping levels or using them out of order can confuse screen readers, affect search engine rankings, and make your content harder to understand.
<h2 class="user-name">Jessica Randall</h2> <h4 class="user-location">London, United Kingdom</h4>
- I would put these into a
<ul> <li>
, and the text should be wrapped with a<a>
so it is accessible with a keyboard using the tab key, Using an<a>
tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a<button>
or a<div>
not intended for links.
<div class="user-socials"> <button class="btn-socials" onclick="window.open(href='https://github.com', '_blank');">GitHub</button> <button class="btn-socials" onclick="window.open(href='https://www.frontendmentor.io/', '_blank');">Frontend Mentor</button> <button class="btn-socials" onclick="window.open(href='https://linkedin.com/', '_blank');">LinkedIn</button> <button class="btn-socials" onclick="window.open(href='https://x.com/', '_blank');">Twitter</button> <button class="btn-socials" onclick="window.open(href='https://www.instagram.com/', '_blank');">Instagram</button> </div>
-
Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset
-
While
px
is useful for precise, fixed sizing, such asborder-width
,border-radius
,inline-padding
, and<img>
sizes, it has limitations. Pixels don't scale well with user settings or adapt to different devices, which can negatively impact accessibility and responsiveness. For example, usingpx
for font sizes can make text harder to read on some screens, Check this article why font-size must NEVER be in pixels. In contrast, relative units likerem
and adjust based on the user’s preferences and device settings, making your design more flexible and accessible. Usepx
where exact sizing is needed, but prefer relative units for scalable layouts. If you want a deeper explanation watch this video by Kevin Powell CSS em and rem explained. Another great resource I found useful is this px to rem converter based on the default font-size of 16 pixel. -
Using
rem
orem
units in@media
queries is better thanpx
because they are relative units that adapt to user settings, like their preferred font size. This makes your design more responsive and accessible, ensuring it looks good on different devices and respects user preferences.
You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟
Marked as helpful0 - Your heading elements
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord