Social links profile w/ Tailwind CSS

Community feedback

• 

  Aakash Verma•9,520

  @skyv26Posted 2 months ago

  Hi @MichalJirak,

  Great work on the project! Here are a few suggestions for improvement:

  1. Move Inline Styles to a CSS File: Instead of putting the styles inline, please move the highlighted code to a dedicated CSS file. This will help keep your code cleaner and more maintainable.
     Highlighted Code

  2. Use Semantic HTML Tags: Instead of using <div> elements for your list of social media links, it's better to use semantic tags like <ul> and <li>. Also, replace the static text with anchor (<a>) tags to make the links accessible and SEO-friendly.
     Example:

     <ul class="flex flex-col items-center gap-4 px-2">
       <li><a href="your-github-link" class="w-full text-center text-sm bg-[var(--Grey700)] rounded-lg p-4">GitHub</a></li>
       <li><a href="your-frontend-mentor-link" class="w-full text-center text-sm bg-[var(--Grey700)] rounded-lg p-4">Frontend Mentor</a></li>
       <!-- Add other links here -->
     </ul>
     

  3. Add Hover Effect on Buttons: The hover state for your buttons is missing, which is part of the project requirement. Adding the following class will resolve this:

     hover:bg-[#256252]
     

  Hope this helps! Keep up the great work 👍

  Best,
  Aakash

  0

  ---

  

  Michal Jirák•50

  @MichalJirakPosted 2 months ago

  @skyv26 thank you for valuable feedback! Yes, there's always more custom css than I imagine at first :) Wasn't even sure how responsive these works should be and if somebody even hovers over them etc. Will keep that in mind!

  1
• 

  Bhuvnesh Upadhayay•2,000

  @bhuvi819381Posted 2 months ago

  Hello Brother

  Everything looks good, Congratulations 👏

  A thing i want to suggest Instead of div you can use a tag for links Like github twitter etc etc

  0

  ---

  

  Michal Jirák•50

  @MichalJirakPosted 2 months ago

  @bhuvi819381 okay okay, didn't know about this. Thanks for that :)

  1