Skip to content
Submitted 10 months ago

Social links profile (html & css only)

Ciprian Danilaā€¢110
@cipdanila
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Improvements made to the project based on HTML5 semantics, accessibility, and BEM.

What challenges did you encounter, and how did you overcome them?

It wasn't really that difficult, so I wouldn't say I encountered too many difficulties.

What specific areas of your project would you like help with?

I would try a different approach to achieve something of higher quality. It seems it didn't quite turn out as intended.

Community feedback

  • Daniel šŸ›øā€¢44,310
    @danielmrz-devPosted 10 months ago

    Hello @cipdanila!

    Your project looks awesome!

    I have just one suggestion:

    šŸ“Œ The hover effect on the links is supposed to turn the container Green, not OffBlack.

    This is your code:

    .container a:hover {
    background-color: var(--off-black);
}

    And this is how it is supposed to be:

    .container a:hover {
    background-color: var(--green);
}

    I hope it helps!

    Other than that, great job!

    Marked as helpful
    0
    Ciprian Danilaā€¢110
    @cipdanilaPosted 10 months ago

    @danielmrz-dev Thank you so much it was helpful!

    1
  • Karim Aymanā€¢320
    @KarimAyman97Posted 10 months ago

    hi Ciprian Danila great work you did. I have some accessibility and semantics recommendations for you.

    1- try to change <div class="container"> to a <main class="container"> and the <div class="attribution"> to a <footer class="attribution">

    this does not affect your project visually but it improves SEO optimization as well as the accessibility of your project.

    I hope it helps!

    Other than that, great job!

    Marked as helpful
    0
    Ciprian Danilaā€¢110
    @cipdanilaPosted 10 months ago

    @KarimAyman97 Thank you for suggestions!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord