Design comparison
Solution retrospective
Feedback will be appreciated!!
Community feedback
- @Dharmik48Posted about 3 years ago
Hey👋,
Your solution is really great! But maybe just add some
box-shadow
to your card refer https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow to learn more aboutbox-shadow
Keep it up👍
Marked as helpful0@Tomi-pterPosted about 3 years ago@Dharmik48 Thanks, i've added it. Didn't really notice it the first time. 👍🏾
0 - @dwhensonPosted about 3 years ago
Lovely job here!! I don't have much to say!
My only small suggestion is that the
span
element around the $29, should probably be inside yourh3
.As at the minute anyone navigating the page by headings would only hear 'per month' announced. (I'm not sure whether this should really be a heading either?)
This will make things a bit tricker to line up, but
vertical-align: middle
should help you here...Great work! Keep it up!!
Cheers Dave
Marked as helpful0@Tomi-pterPosted about 3 years ago@dwhenson Thanks for the
vertical-align: middle
tip. I had to switch the 'per month' and $29 positions so the opacity wouldn't affect the $29. Everything should be good now. Thanks once again0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord