Single price grid with SASS

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Rael! 👋

  Well done on this challenge! Your solution responds well. Yeah, Grid is awesome when it comes to layout. Flexbox is handy when it comes to position something within some container. Here's my suggestion:

  • Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.
  • Instead of multiple paragraphs use unordered list <ul> for .right-box__text.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Rael•270

  @RaelianPosted over 3 years ago

  @tediko Thank you! I actually considered using <ul> for the paragraphs but I hesitated, thinking it would actually be the opposet of helpful and maybe even confuse people or be considered as bad practice. It sounds like it would of actually been the right choice from what you told me. Something I'll keep in mind for next time!

  I've also not used many semantic elements since I wasn't sure if they would fit since it's not a 'traditional' site so to speak. It seems that I've been a bit too rigid in my views by not using them so I'll try to incorporate them more into my projects.

  Thank you once more for the suggestions! ^^

  0