Design comparison
Solution retrospective
Hi 👋
This is my solution to Frontend Mentor - Single Price Grid Challenge. I have some issues about mobile design, any feedback will make me much better developer :) .
Community feedback
- @adonmez04Posted almost 2 years ago
Hi, @erenymo. It's a good solution. Keep coding. I have some suggestions for you.
1 - You should use
h1
tag in your page. It's necessary for screen readers and search engines. Be careful your page hierarchy. You can useh1
tag instead ofh2
in your page.2 - You can use the universal selector for the global reset.
* { margin: 0; padding: 0; box-sizing: border-box; }
box-sizing: border-box;
is so important. This topic is related to the box-model. It is one of the most important topics in CSS. Be sure to understand the fundamentals of CSS. This will make you feel more comfortable. Please check the resources.Learn CSS Box Model In 8 Minutes
box-sizing: border-box explained
3 - If you want to learn CSS fundamentals in depth, I highly recommend Jonas Schmedtmann's HTML&CSS courses on Udemy.
I hope these will help you to improve your perspective. Keep coding. All the best.
Marked as helpful1@erenymoPosted over 1 year ago@adonmez04 I will try to follow these guidelines more in the next projects, Thanks for your feedback ^^
1 - @J-HernandezMPosted almost 2 years ago
Maybe you should try to learn CSS GRID and apply it to this project. Usign in desktop a 4x4 grid meanwhile in mobile use a 1column x 3 row, change that using media queries. Use this resource to learn grid basics https://cssgridgarden.com/#es When you check that the rules that im reffering to are
grid-template-area grid-area
or just the columns or just the rows
Marked as helpful1@erenymoPosted over 1 year ago@J-HernandezM Thanks for your direction man, I will take a look CSS GRID. <3
0 - @LuieitalianPosted almost 2 years ago
Hi! I think you should start making it mobile-first and then move on to the desktop design with media queries as @J-HernandezM mentioned. If you have any further questions, I will do my best to help you! Cheers
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord