Single Price Grid Component

Community feedback

• 

  hitmorecode•6,250

  @hitmorecodePosted over 1 year ago

  Congratulations well done. I took a look at you markup and css and it's pretty good well done. Just a few suggestions.

  • When going to mobile there is no margin on the left and right side of the card. The card is stretching from side to side. Add a small margin to fix this.
  • When creating custom variables (for example for colors) this is how I do it.

  :root {
  --primary-cyan: hsl(179, 62%, 43%);
  --primary-bright-yellow: hsl(71, 73%, 54%);
  --primary-white: #fff;
  --neutral-light-gray: hsl(204, 43%, 93%);
  --neutral-grayish-blue: hsl(218, 22%, 67%);
  }
  

  This way it's easier to see which one is which when applying.

  Marked as helpful

  1

  ---

  

  Edi Carlos•130

  @ediCarlosSilvaPosted over 1 year ago

  Hi @hitmorecode

  I saw that margin in the design. But I thought it wasn't necessary. I am going to do what you told about variavel names and about the margin in Mobile layout. Thanks.

  0