Skip to content
Submitted about 3 years ago

Single price card using css grid

Marialba Córdova•60
@Marialba16
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Single price grid component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi guys, how are you? This is my challenge number 5, as in the previous ones, I would like to read your comments on how I can improve or what should I avoid when coding. Thanks!!

Community feedback

  • dewslyse•3,025
    @dewslysePosted about 3 years ago

    Hello Marialba! Congrats on completing another challenge. This is very good. Some suggestions for your consideration:

    • You should set a max-width on your .container-card. I believe the the width for this component is 635px.
    • You could also use <li> for the why us section
    <h3>Why Us</h3>
<ul>
   <li>Tutorials by industry experts</li>
   <li>Peer & expert code review</li>
   <li>Coding exercises</li>
   <li>Access to our GitHub repos</li>
   <li>Community forum</li>
   <li>Flashcard decks</li>
   <li>New videos every week</li>
</ul>
    • Remember to wrap the content within the <body> in a main tag.
    • [ <button><a href="#">Sign Up</a></button>] <a> cannot be a descendant of <button>. Use one or the other.

    Happy coding!

    0
    Marialba Córdova•60
    @Marialba16Posted about 3 years ago

    Hello! Thanks again for your comment, I did not remember to use <ul>, now that you say it if it is more practical and feasible, and regarding the max-width I still do not understand it much and that is why I do not use it, but I'll start to put it into practice too. Thanks, again @dewslyse!!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord