single card with grid

Community feedback

• 

  Aakash Verma•6,710

  @skyv26Posted almost 3 years ago

  Hi! Shawky, I am randomly checking people submission and trying my best to solve people's issues. I checked your work and also saw design responsiveness.

  1. Your Join community card have unnecessary space at the bottom just add grid-row-end: none; in your section1 class.

  2. Your signup section card also have space at bottom use display: grid; in css property it will take space and make your work little bit more better.

  3. In mobile view, your layout touches the device bottom edge and I think you need to add margin at bottom and top both sides.

  I hope you understand and might be it will be helpful for you.

  Best of luck

  Marked as helpful

  0

  ---

  

  shawky sobhy•340

  @shawkysobhyPosted almost 3 years ago

  @skyv26 thanks i don't notice these when i coding ,and make gird-row-end none as you say but i can not found about these 'value none ' in mdn can you explain what it do and resource about it

  2- i make sign up section with flex box (coulmn,space around ) and it become nice than first thank you Aakash Verma🤍for feedback and you can also feedback in my other challenge

  1