Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

SimpleQR

Ikapoccβ€’ 170

@Ikapocc

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Panjiβ€’ 2,110

@pperdana

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have some additional recommendations for your code that I think you'll find interesting and valuable.

πŸ“Œ Add <main> tag as semantic HTML in code

  • The <main> tag is a semantic HTML element that is used to define the main content of a web page.

  • The <main> tag should be used to wrap the primary content of a web page, such as the main article, section, or body of text.

for example code:

<main>
  <div class='container'>
    <h1>Article Title</h1>
    <p>Article content goes here...</p>
    .......................
  </div>
</main>

In the example above, the <main> tag is used to wrap the <div> tag, which contains the primary content of the web page. This tells both human readers and search engines that the content inside the <main> tag is the most important and relevant content on the page.

I hope you found this helpful!

Happy codingπŸ€–

0
Ecem Gokdoganβ€’ 9,380

@ecemgo

Posted

Some recommendations regarding your code that could be of interest to you.

  • If you want, I recommend Flexbox as an idea for this solution as well as Grid:
  • In order to center the card correctly, you'd better add flexbox and min-height: 100vh to the body
  • For the color of the screen, you can use the recommended color in the body
body {
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100vh;
  /* background-color: #dafaf8; */
  background-color: hsl(212, 45%, 89%);
}
  • If you use flexbox in the body, you don't need to use margin in the .row to center the card
  • If you use max-width instead of width, the card will be responsive.
.row {
  /* width: 20%; */
  max-width: 320px;
  /* margin: 100px auto; */
}
  • After the updates above, you don't need to use .container, you can remove it
/* 
.container{
    display: grid;
    place-items: center;
} 
*/

Hope I am helpful. :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord