Skip to content
Submitted over 3 years ago

Simple landing page

Mahmoud Ashraf•310
@m-Ash1
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Huddle landing page with a single introductory section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

what is better in flexbox ? 1- using percentages while sizing child elements 2- using pixels while sizing child elements

Community feedback

  • Dušan Lukić•1,660
    @dusanlukic404Posted over 3 years ago

    And yeah, I forgot to answer on your question. You should use px just for borders, box-shadows, outlines etc. They won't make your site responsive because they are very static. Using rem/em or % is much better option for width, height...

    Marked as helpful
    0
    Mahmoud Ashraf•310
    @m-Ash1Posted over 3 years ago

    @dusanlukic404 thank you so much I really appreciate your feedback

    0
  • Dušan Lukić•1,660
    @dusanlukic404Posted over 3 years ago

    Hey Mahmoud, well done!

    I have some suggestions for you:

    • The right part of that main box shouldn't have so much padding on top and bottom. Use 10px on top and bottom instead of 70px
    • Also, the same problem is on your header. Make top and bottom padding 20px (not 50px)
    • When you change that paddings you will lose that vertical scrollbar
    • In my opinion line height in <p> and <h1> is too big
    • Add transition on button
    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord