@vanzasetia
Posted
Hi, Ngewe! 👋
Good effort on this challenge! 👍 It's great that you are using width and height attributes for every image. By using those attributes, it would optimze the CLS (Cumulative Layout Shift).
However, I thought that there are two things that can be better.
- Firstly, I would recommend removing all the
nbsp. I'm not sure what is the use case of them, but if you want to create a space between the two elements, I would recommend using flexbox. - Secondly, on mobile landscape view, the card is broken. So, I would recommend you learn more about CSS and then come back and fix this issue.
Also, I would highly recommend removing all the tags that are currently applied to this solution. You don't use any of the technologies to build the site.
It's important that you are only using the correct tag for your solution because in the future if you are going to set yourself as available for work, and then the recruiters see your solution tagged with Sass or JSS but you're not actually using it, you might get a red flag.
All I have to say is that you need to learn more a bit about CSS in general and about responsive design and then if you want you can fix all the issues that I have mentioned.
That's it! I hope this information is useful! 😁
@IzzyDoes
Posted
@vanzasetia thank you so much, I’ll take note of these right now and make fixes to them.
@vanzasetia
Posted
@IzzyDoes You're welcome! 😉
