Design comparison
SolutionDesign
Solution retrospective
give me feedbacks.
happy new year.
Community feedback
- @Sam-GulikerPosted almost 3 years ago
Hi,
Clean solution you've got there. The only thing I could give feedback on is: Use landmarks. For example, a main, header, footer etc. More about this topic can be found here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/main
Happy coding and a good new year
Marked as helpful1@sinredneranPosted almost 3 years ago@Sam-Guliker yeah, i know this problem and i will use these accessibility tags in future projects.
thanks
0 - @anoshaahmedPosted almost 3 years ago
To get rid of the accessibility/HTML issues shown in your Report:
- wrap everything in your body in
<main>
OR use semantic tags OR giverole=""
to the direct children of your<body>
... Click here to read more - have at least one
<h1>
in your code
Good job! :)
Marked as helpful0 - wrap everything in your body in
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord