sign-up form

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted about 3 years ago

  Hey, your solution looks great, responsiveness seems fine too! The only thing I noticed, you forgot to include the email validation in your function so now it only throws an error if you try to submit your email empty ^^

  1

  ---

  

  superOzzy•345

  @superozzyPosted about 3 years ago

  @FluffyKas thank you 😃i will check it out and upadate my solution!

  0
• 

  Dharmik_487•1,740

  @Dharmik48Posted about 3 years ago

  Hey👋,

  Great job with the solution😄! It looks really nice, just a few issues:

  • Your hierarchy is like body->.container->wrapper, and here I don't think that the .container or .wrapper, any one of these is unnecessary.
  • Also try to add transition to the hover states.

  Apart from these, it is really good, Keep Developing👍.

  0

  ---

  

  superOzzy•345

  @superozzyPosted about 3 years ago

  @Dharmik48 hey thanks for the tips,i keep both of the classes because it seemed easier to me when the time came for the media queries! I will also check the transition!Thank you for your time!

  0