Semantically QR Code Component Page with Basic HTML & CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  ---

  iMAGES 📸:

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute.

  ---

  • The alt attribute should explain the purpose of the image.

  ---

  • E.g. alt="QR code to frontendmentor.io"

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  F4Bz3•200

  @FabianWassermannPosted over 1 year ago

  Great work! Here are some points for improvement.

  • You don't need to comment every end-tag. I make empty lines or commented lines before i start new sections or elements.
  • Your img needs an alt text to show if the image can't be shown.
  • It works with only one or two media queries as-well. Set a fixed max width in rem or px and a fixed margin left and right. On smaller devices I would recommend to shrink down the text a bit.

  Keep it going!

  Marked as helpful

  1