Made with HTML and SCSS

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted almost 3 years ago

  Hey, really nice work on this one. The overall layout looks great.

  Semandr already gave information about where you can see bem methodology which I really like as well:>

  Here are some other suggestions for the site:

  • Avoid using height: 100vh on a large container like the main as this makes the element's height capped based on the viewport/screen's height. Instead use min-height: 100vh so that the element will expand if it needs to.
  • Those wave-background-images, they could just be used as a value for the background property of either body or main tag on this one so that you could avoid creating extra img tag. But if you insist on using img tag, add an extra aria-hidden="true" on the img tag so that they will be hidden for screen-reader.
  • You could change the header tag on this into div since header tag is used for sectioning when there is a content but the image that it nest is not visible since it has an alt="' which should be. You can use header inside of article, you can have a search about more into using header as sectioning.
  • Extra aria-hidden="true" on the vector/illustration and for the music-icon as well.

  Those only, actually the site looks great to be honest^^. Great job again on this one.

  Marked as helpful

  1

  ---

  

  derrick•30

  @derrick-itPosted almost 3 years ago

  @pikapikamart Thanks for the guide !! I forgot that i could just use it as a background-image instead of playing absolute html image. also i'll read things about aria-hidden and refactor this real soon

  1
• 

  Semandr•170

  @SemandrPosted almost 3 years ago

  Hi. Try to read this about BEM: https://en.bem.info/methodology/quick-start/

  Marked as helpful

  1

  ---

  

  derrick•30

  @derrick-itPosted almost 3 years ago

  @Semandr Thank you ! i'll start trying it out on my next practice

  0