Design comparison
Solution retrospective
Didn't end up doing the tablet layout but did do the mobile layout for devices 375px wide
Community feedback
- @emestabilloPosted over 3 years ago
Hey @asim-ali5514, seems like your repo is private so not able to take a peek at your code. I'm curious to know how you structured your Nextjs project. My thoughts:
-
There's plenty of wiggle room to extend the mobile view beyond 375px
-
The mobile menu doesn't close when you click on a link
-
Contents of map and
.homeInfo
are overflowing to the side (left and right) margins of the page, I think because there's an explicit width of 1400px -
The page is not centered, more evident in larger screens
-
Accessibility report needs attention
Hope this helps!
Marked as helpful1@asim-ali5514Posted over 3 years ago@emestabillo Thanks so much for the feedback. I was wondering how I would be able to stop the contents of map and homeInfo from overflowing as I am new to making responsive websites
1@emestabilloPosted over 3 years ago@asim-ali5514 I haven't tried Tailwind, but my approach would probably be creating a div which takes care of the left and right margins, and then placing all of the contents of the page inside. This way, the margins are consistent (and contained) in every single page. I also recommend watching tutorials on responsive design such as Kevin Powell's video to give you ideas.
0@asim-ali5514Posted over 3 years ago@emestabillo Thanks so much for the advice! , I'm currently working on the 8-page planet sitechallenge, and I'm going for a fully responsive design this time. I would love for you to give me some feedback once I complete it.
0@emestabilloPosted over 3 years ago@asim-ali5514 Oh nice! Sure let me know. Good luck!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord