SASS mixins, HTML, JS

Community feedback

• 

  Cats-n-coffee•670

  @Cats-n-coffeePosted almost 2 years ago

  Hi Carlos!

  Nice solution! And great questions, I'll try to help answering them. I can't see you code on Github because the link seems broken. It seems that you might need to ask for consent to store data on the user's browser storage depending on what kind of data you are trying to store. Accepted answer on this post does a good summary https://law.stackexchange.com/questions/30739/do-the-gdpr-and-cookie-law-regulations-apply-to-localstorage. From what I remember it can also depend on the country we're talking about, the EU (as an example) being more strict than other countries.

  I'm not sure about a set of rules for calculators, the only thing I would suggest is to look into how Javascript deals with certain operations. You might have encountered NaN, which shows up in certains cases (which you can find in the docs). This article does a good job at handling division by zero in Js https://www.educative.io/answers/how-does-javascript-handle-divide-by-zero. I tried doing 0/0, 1/0 and they both return . in your calculator.

  One last thing, from looking at the Js source in the devtools, you could probably use let or const instead of var, because var is in the global scope which can lead to unexpected bugs.

  Hope this help!

  Marked as helpful

  1

  ---

  

  Carlos E Alford•285

  @webshurikenPosted over 1 year ago

  Hi @Cats-n-coffee,

  I updated my github profile name and didn't update the links. I was away from this site for a while, but now Im back.

  Thanks for taking the time to leave me feedback. Very interesting about asking for consent when storing data on the browser, didn't even cross my mind. I have noticed the division also, thank you. I will look to fix these bits.

  0