Room Homepage (responsive and with SCSS)

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, great work on your first challenge here in FEM.

  Your layout is almost pixel perfect, points for that one. Layout in desktop is good and the mobile is good as well.

  One thing to concern about is that a tag in your slider, since you use a tag right here right, so every time a user clicks on it, it works but it refreshes the site. You can see it when you make the browser in mobile view, then scroll down a bit and click the slider button. It refreshes and goes to the top. You could prevent this by adding a .preventDefault in your click eventListener. So that it won't refresh every time a user clicks on it

  Also while you're at it, try to clear some accessability issues ^^

  1

  ---

  

  Daniel•250

  @daniel-hennigPosted over 3 years ago

  @pikamart hey Raymart, thank you for your feedback, I really appreciate that! These are updated now on my Github as well as in the live version.

  0

  

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  @daniel-hennig Awesome works really good, even before and now, it doesn't refresh^^

  0