Rock Paper Scissors Lizard Spock

Community feedback

• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted over 4 years ago

  Adding another thumbs up Alex. Great work...I’m already sweating planning this project in my head lol. Liked and bookmarked!

  1
• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  Hey Alex, awesome work on this challenge. Your solution looks amazing and I love the additional animations. They really improve the experience and make it even more fun to play!

  What's happening with the localStorage for you? For me, it works without a problem in the preview and saves the score even when you refresh the page. Interested to hear about what's happening for you.

  One tiny improvement I'd recommend would be to add position: absolute to the Rules button in the bottom right corner. This would stop it from jumping around when the game moves through the various states.

  Amazing work, as always! 🙌

  1

  ---

  

  Alex Kim•1,325

  @alex-kim-devPosted over 4 years ago

  Hello Matt, thanks for the feedback! Glad to hear you liked it :) I checked the preview page in different browsers and it works fine in Firefox & Opera, but in Chrome & Brave I get

  Uncaught DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document. at this line of code.

  That's on linux (Manjaro). What seems odd to me is that even checking with if (window.localStorage) before accessing the storage doesn't help.

  1

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  @Alex-K1m that's very odd. The way I'd do it would be:

  const score = parseInt(localStorage.getItem('score'))
  

  But I'm not sure that would change anything. I'm using Chrome on MacOS and it's working perfectly through the preview 🤷‍♂️

  0

  

  Alex Kim•1,325

  @alex-kim-devPosted over 4 years ago

  @mattstuddert I figured out the problem - the third-party cookies are turned off in my browser's settings. It turns out this setting also blocks access to local storage to prevent tracking. (at least for Chrome). I enabled them for frontendmentor and it worked. I also added some code to catch the error and now it doesn't crash even if the access is blocked - the score just won't persist between sessions.

  1

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  @Alex-K1m nice work! That’s great that you’ve resolved the issue 👍

  0