hitmorecode• 6,230
@hitmorecode
Posted
Nice well done. Ok, let's start with html
html
- Make it a habit of setting your html like this
<body>
<main>
/* everything else goes in here */
</main>
</body>
- You have an empty div, is ther a reason for this?
- You have a div with the class container, but the container is not defined in your css. This extra div layer is actually not needed.
- You have two headers and no h1, I suggest to either make Your Result or Summary a h1. Every site must contain one h1.
- The
<strong>wasn't really necessary, because you are going to style it with css. You could have used a p tag also. - You did something I've never seen before. You have
<ul>inside the<ul>you have a<div>and inside the<div>a<li>. I don't know if this is OK or not, I'll have to do some research. Maybe it would be better to do it like this.
## This I've seen it before and it seems logic.
<ul>
<li>
<div></div>
</li>
</ul>
css
- Like mentioned above, make it a habit of using
min-height: 100vh;on the body. This is important to make to body responsive to it's content - Make more use of flexbox or grid to place the card in the middle of the page and remove all margins that are doing this at the moment.
Marked as helpful
4
Maduka Chisom• 90
@chisomwest
Posted
Thank you so much for the corrections. I learned a lot and will implement my learnings going forward @hitmorecode
0
