P
Luciano Lima• 1,290
@LucianoDLima
Posted
Hey, well done on completing the challenge!
A few things you could add to improve your website even more, do bear in mind I don't know next.js, so I can't comment on your code per say
- Add a max-width so it doesn't stretch all the way when user zooms out
- From I could tell, every time I write a digit, the search box seems to be sending a fetch request to the api. I think you could improve your code so that it doesn't happen. Right now we already have all the data displayed on screen right away, so there is no reason to fetch a data that has already been retrieved
- Your commit history on github is very general, I think you could start giving more meaninful commit comments, you can take a look at this article that goes a bit more over it
Once again, well done on completing this challenge!
Marked as helpful
0
Karim Ayman• 320
@KarimAyman97
Posted
@LucianoDLima thank you :)
1